Fix #7757: Do auto-parameter-untupling also for overloaded methods #7766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The case where a lambda is passed to a single method is handled in `typedFunction`. But overloading resolution failed before getting there.
anatoliykmetyuk
suggested changes
Dec 17, 2019
There was a problem hiding this comment.
This doesn't work if you specify the types of the params of the lambda explicitly:
trait Foo
def g(f: ((Int, Int)) => Int): Int = 1
def g(f: ((Int, Int)) => (Int, Int)): String = "2"
@main def Test =
val m: Foo = ???
m.g((x: Int, b: Int) => (x, x))-- [E134] Type Mismatch Error: /Users/kmetiuk/Projects/scala3/pg/sandbox/iss3.scala:7:4
7 | m.g((x: Int, b: Int) => (x, x))
| ^^^
| None of the overloaded alternatives of method g in trait Foo with types
| (f: ((Int, Int)) => (Int, Int)): String
| (f: ((Int, Int)) => Int): Int
| match arguments ((Int, Int) => (Int, Int))
1 error found
|
@anatoliykmetyuk It's too late to fix this now (the fix looks quite a lot more complicated). Can you make an issue so that we come back to this? But I think the current fix should be merged since it is tripping people up. |
|
I managed to fix the issue after all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The case where a lambda is passed to a single method is handled in
typedFunction.But overloading resolution failed before getting there.